28 May
2020
28 May
'20
1:01 a.m.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41555 )
Change subject: mb/google/hatch/vr/puff: Setup PL2 and PsysPL2 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41555/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41555/4/src/mainboard/google/hatch/... PS4, Line 88: #define ROP_MAX (30) Why do you define ROP_MAX? It seems never be used.
--
To view, visit https://review.coreboot.org/c/coreboot/+/41555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7de614d58366158a566563990ee1ecc8c0110bc
Gerrit-Change-Number: 41555
Gerrit-PatchSet: 4
Gerrit-Owner: Gaggery Tsai gaggery.tsai@intel.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com
Gerrit-Reviewer: Ryan Lin ryan.lin@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 07:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment