Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37449 )
Change subject: sb/amd/cimx/sb800: Postpone Sb_Poweron_Init() call
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37449/5/src/northbridge/amd/agesa/f...
File src/northbridge/amd/agesa/family14/state_machine.c:
https://review.coreboot.org/c/coreboot/+/37449/5/src/northbridge/amd/agesa/f...
PS5, Line 52: sb_Poweron_Init();
sb_Poweron_Init is still called in board_BeforeAgesa for each mainboard making it a doubled call. […]
The one in board_BeforeAgesa() is supposed to be removed with !ROMCC_BOOTBLOCK transition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a28eaa2cf70b770b022760a2380ded0f43e9a6f
Gerrit-Change-Number: 37449
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Dec 2019 12:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment