[coreboot-gerrit] Change in coreboot[master]: util/spd_tools: Add LP5 support for ADL

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Reka Norman, Sridhar Siricilla, Nick Vaccaro, Balaji Manigandan, Krishna P Bhat D, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58679 )

Change subject: util/spd_tools: Add LP5 support for ADL
......................................................................

Patch Set 8: Code-Review+1

(4 comments)

Patchset:

PS8:
> It’s been bothering me how ADL-specific this implementation is. E.g. […]

I completely agree with your assessment Reka. This is the first platform we're supporting LP5 on, so we may have to make some tweaks in the future depending on other vendors or chipsets. This is the approach to make things the most generally applicable for all chipsets.

File util/spd_tools/src/spd_gen/lp5.go:

https://review.coreboot.org/c/coreboot/+/58679/comment/d8481997_3f24b8b1 
PS5, Line 456: ok == false
nit: I think the convention is
`; !ok {`

https://review.coreboot.org/c/coreboot/+/58679/comment/dce75c7b_9ab51db6 
PS5, Line 484: ; ok == false
`; !ok {`

File util/spd_tools/src/spd_gen/lp5.go:

https://review.coreboot.org/c/coreboot/+/58679/comment/61050676_83672385 
PS8, Line 603: k == false
nit: `!ok`