Attention is currently required from: Reka Norman, Sridhar Siricilla, Nick Vaccaro, Balaji Manigandan, Krishna P Bhat D, Karthik Ramasubramanian.
Patch set 8:Code-Review +1
4 comments:
Patchset:
It’s been bothering me how ADL-specific this implementation is. E.g. […]
I completely agree with your assessment Reka. This is the first platform we're supporting LP5 on, so we may have to make some tweaks in the future depending on other vendors or chipsets. This is the approach to make things the most generally applicable for all chipsets.
File util/spd_tools/src/spd_gen/lp5.go:
Patch Set #5, Line 456: ok == false
nit: I think the convention is
`; !ok {`
Patch Set #5, Line 484: ; ok == false
`; !ok {`
File util/spd_tools/src/spd_gen/lp5.go:
Patch Set #8, Line 603: k == false
nit: `!ok`
To view, visit change 58679. To unsubscribe, or for help writing mail filters, visit settings.