Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )
Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede...
PS4, Line 2: WT:F
Karthik - can you please confirm that this is WT:F part and not WT:E? Both use the same SPD, so it wouldn't matter much, but for correctness (matching with schematics), I think it would be good to put in the right name here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c
Gerrit-Change-Number: 41878
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aamir Bohra
aamirbohra@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 00:12:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment