Change in coreboot[master]: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

29 May 2020 29 May '20

10:53 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.

Part: NT6AP256T32AV-J2 Manufacturer name bytes are set to 0.

Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/1

diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc new file mode 100644 index 0000000..80bea09 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +MEM_TYPE = lp4x +SPD_SOURCES = +SPD_SOURCES += spd-8.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:F +SPD_SOURCES += spd-9.hex # ID = 1(0b0001) Parts = NT6AP256T32AV-J2 diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt new file mode 100644 index 0000000..9d5ced3 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:F 0 (0000) +NT6AP256T32AV-J2 1 (0001) diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt new file mode 100644 index 0000000..08daad4 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +MT53E512M32D2NP-046 WT:F +NT6AP256T32AV-J2

Attachments:

attachment.htm (text/html — 5.3 KB)

Show replies by date

Furquan Shaikh (Code Review)

30 May 30 May

1:06 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41878

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Part: NT6AP256T32AV-J2 Manufacturer name bytes are set to 0.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

3 Jun 3 Jun

1:30 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jun 2020 23:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:08 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41878

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Part: NT6AP256T32AV-J2 Manufacturer name bytes are set to 0.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

2:12 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... PS4, Line 2: WT:F Karthik - can you please confirm that this is WT:F part and not WT:E? Both use the same SPD, so it wouldn't matter much, but for correctness (matching with schematics), I think it would be good to put in the right name here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 00:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:46 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41878

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.

Part: NT6AP256T32AV-J2 Byte# Current New Explanation 4 0x14 0x15 This part has only 1 die. Hence, density per die is 8Gb. 6 0x90 0x04 1 die in package and 2 channels per die. Manufacturer name bytes are set to 0.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

7:59 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41878/6//COMMIT_MSG@19 PS6, Line 19: 4 0x15 0x16 This part has only 1 die. Hence, : density per die is 16Gb. : 6 0x90 0x04 1 die in package and 2 channels per : die. This has changed from before based on the recent findings about how dies and channels are calculted.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 05:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:47 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41878

to look at the new patch set (#8).

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 8 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nick Vaccaro (Code Review)

7:30 p.m.

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 17:30:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8:14 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... PS4, Line 2: WT:F

...

Karthik - can you please confirm that this is WT:F part and not WT:E? Both use the same SPD, so it w […]

It is actually WT:E at least as per the data programmed in CBI

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 18:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:09 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... PS4, Line 2: WT:F

...

It is actually WT:E at least as per the data programmed in CBI

Thanks! I will update this. Is it true for Waddledoo and Wheelie too?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 19:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:52 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... PS4, Line 2: WT:F

...

Thanks! I will update this. […]

Yes, all of them are using the same micron part at the moment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 19:52:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:28 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Nick Vaccaro, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41878

to look at the new patch set (#10).

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:E Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/41878/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

10:29 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt:

https://review.coreboot.org/c/coreboot/+/41878/4/src/mainboard/google/dedede... PS4, Line 2: WT:F

...

Yes, all of them are using the same micron part at the moment.

Done. Updated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 20:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:30 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41878/6//COMMIT_MSG Commit Message:

...

This has changed from before based on the recent findings about how dies and channels are calculted.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 20:30:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4 Jun 4 Jun

12:24 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 22:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Jun 6 Jun

11:30 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go

This change adds mem_list_variant.txt that contains the list of memory parts used by waddledee and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.

In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.

Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41878 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc new file mode 100644 index 0000000..37f25e0 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc @@ -0,0 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E +SPD_SOURCES += spd-7.hex # ID = 1(0b0001) Parts = NT6AP256T32AV-J2 diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt new file mode 100644 index 0000000..3f2a5db --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +NT6AP256T32AV-J2 1 (0001) diff --git a/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt new file mode 100644 index 0000000..a6786e3 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +MT53E512M32D2NP-046 WT:E +NT6AP256T32AV-J2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 11 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

7 Jun 7 Jun

7:39 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41878 )

Change subject: mb/google/dedede/var/waddledee: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................

Patch Set 11:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5100 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5099 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5098 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5097

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a68a29ca3632e22f3960c9fc44acf3ce4f87c9c Gerrit-Change-Number: 41878 Gerrit-PatchSet: 11 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 07 Jun 2020 17:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1430

days inactive

1439

days old

coreboot-gerrit@coreboot.org

17 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Nick Vaccaro (Code Review)
Patrick Georgi (Code Review)