Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )
Change subject: sc7180: GPIO: I2S configuration for google/trogdor ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG@12 PS2, Line 12: layout was changed. I'm confused, does this commit message actually have anything to do with the patch? I mean the patch is fine, I wanted the pull to be changed, but that's not what makes it break on rev1 right? And the bug below was mostly about adjusting the volume in depthcharge, not the GPIO config here.