build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 45:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/3fc911af_5976b12f PS45, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6a7015d6_d0f54318 PS45, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1820cfb_bf2cec11 PS45, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7a7aad77_eca46e0e PS45, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/08d1b50a_545226ee PS45, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fdd51412_4c0fc1eb PS45, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d62912f2_6515add0 PS45, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/95491fcb_9387c09e PS45, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/128d6cd8_5cbeb7a6 PS45, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/30d4753c_67c097af PS45, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e5fd3119_abf93048 PS45, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f7372764_35dc6572 PS45, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1ba7121_f4745a20 PS45, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/916ace4c_d7b4e65d PS45, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9ad7e182_dfdb47cd PS45, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5e37bc66_d706a491 PS45, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e2cd38bb_a4b8ecf3 PS45, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b4c5f258_08cd01a9 PS45, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/46ee84b5_b74872e1 PS45, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/00718023_658a99b7 PS45, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6cf3b8d3_5c8a06be PS45, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1aea5362_218f1293 PS45, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3ea4992d_91db0756 PS45, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4c5d9052_47d435da PS45, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cacfe78c_4cec0cfb PS45, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a1d33b0f_fc08d82e PS45, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5cbaee00_363e02e0 PS45, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3e1f6c41_5a04b0a6 PS45, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bc294e41_cfa80ee7 PS45, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/776f0c9c_5a26c2c2 PS45, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f010ad2a_850b9d83 PS45, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6eac6627_7e651d23 PS45, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a8d3d12d_b7df4515 PS45, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b531b22c_262b5855 PS45, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a215ccd6_f4b22da6 PS45, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fac4144d_5b1b3f36 PS45, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f42ddc07_77b3c849 PS45, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/43a7b96f_2aa414e0 PS45, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3c677859_aae2bf68 PS45, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3afa7259_b17695fc PS45, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/462d40cc_9b146ffe PS45, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/57526ff8_d6be2e3f PS45, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/58059ffb_8caf5a3d PS45, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/01073f60_3f4d9908 PS45, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5332a100_66ad61d5 PS45, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e68b55a8_dbfb8f1e PS45, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fc4bd1d4_98b3a7e1 PS45, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f0374df5_66a19073 PS45, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d32fdaa4_c816379f PS45, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18c1e55d_0329e290 PS45, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/33f56835_07379d28 PS45, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/02664bfe_30d0836b PS45, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4f08edb8_e47dd4eb PS45, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/165b0ca8_2c336481 PS45, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/67867c56_25eae513 PS45, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ef570ff9_5aa8b96c PS45, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/70e05e2d_8a232f24 PS45, Line 801: csb_patcher "seabios" "32351" "13" "1cb4656" "a12db828434f0c09433682b17d99649f7518dbff8582ef83b4d523d21b75e2a0" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/90663ccd_4d6b7ec2 PS45, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a741f122_55df2cc6 PS45, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7beace9c_017d83c0 PS45, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1fbc5fd8_7a12e0d6 PS45, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a33baf77_903ab117 PS45, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/05a28bc9_796b453b PS45, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dbefa530_fc4757db PS45, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fc37dd85_5758c523 PS45, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3b40342a_36ce693e PS45, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters