Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45440 )
Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45440/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45440/1//COMMIT_MSG@9 PS1, Line 9: Test steps : : 1. Use python2 script : 2. Run `emerge-board coreboot` twice, so we get bootblock.bin.1 and : bootblock.bin.2 : 3. Run `xxd` on these two bootblock so we get bootblock.bin.1.hex and : bootblock.bin.2.hex : 4. `diff bootblock.bin.1.hex bootblock.bin.2.hex` and record the : difference. (at least, the time info changes) : 5. Migrate to python3 : 6. Similar steps, we get bootblock.bin.py3.hex : 7. `diff bootblock.bin.1.hex bootblock.bin.py3.hex`, the difference is : similar. Could you put these in the TEST field below BUG=...?
TEST=1. Use python2 script 2. ...
https://review.coreboot.org/c/coreboot/+/45440/1/util/mtkheader/gen-bl-img.p... File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/45440/1/util/mtkheader/gen-bl-img.p... PS1, Line 79: if len(argv) != 5: : print('Usage: %s <chip> <flash_type> <input_file> <output_file>' % argv[0]) : print('\t flash_type: emmc|sf') : print('\t chip : mt8173|mt8183') : : exit(1) Use the argparse module? Or at least change to use the f-string.