Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39108 )
Change subject: vendorcode/intel/fsp/fsp2_0: Add FSP header files for Skylake-SP ......................................................................
Patch Set 1:
Anyway, I'm fine with putting these files here so they stick to convention of placing FSP headers. Patrick?
I'd prefer files that come from the outside and shouldn't be changed as part of coreboot development (e.g. a refactor) to end up in vendorcode. Of course they can be changed if their outside copy changes.
This also ties in with some of our lint tests which exclude vendorcode because it's exempt from some coding style rules that apply to the rest of the tree. So it's not just a personal preference ;-)
tl;dr: Everything that's built specifically for coreboot and is maintained as part of coreboot should end up in the appropriate locations in our tree. Everything that only ships with coreboot because we need it to build, but really comes from somewhere else: vendorcode.