Anyway, I'm fine with putting these files here so they stick to convention of placing FSP headers. Patrick?

I'd prefer files that come from the outside and shouldn't be changed as part of coreboot development (e.g. a refactor) to end up in vendorcode. Of course they can be changed if their outside copy changes.

This also ties in with some of our lint tests which exclude vendorcode because it's exempt from some coding style rules that apply to the rest of the tree. So it's not just a personal preference ;-)

tl;dr: Everything that's built specifically for coreboot and is maintained as part of coreboot should end up in the appropriate locations in our tree. Everything that only ships with coreboot because we need it to build, but really comes from somewhere else: vendorcode.

View Change

To view, visit change 39108. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47f102c2c7979da1196f8c6b315d5be558e786c
Gerrit-Change-Number: 39108
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <anpetrov@fb.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 19:48:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment