Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: src/arch: This is an upgrade of SMBIOS to latest version 3.2 ......................................................................
Patch Set 1:
(1 comment)
Sorry for the revert. Please, split out the functional changes (e.g. the cpuid stuff around core/thread count) into their own patch (it's not related to the SMBIOS update, is it?). This change does a lot of things, and I haven't spotted anything yet that is *required* for SMBIOS 3.2.
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG@11 PS1, Line 11:
Please elaborate more about the change. Thread counts on so on.
I think most of all, this commit message needs to give a reason for the changes. If all the added fields (I haven't checked) are optional in SMBIOS 3.2, then this would just be a cosmetic change? Is it done in preperation for other changes in the queue? or just for anticipated future changes?