Sorry for the revert. Please, split out the functional
changes (e.g. the cpuid stuff around core/thread count)
into their own patch (it's not related to the SMBIOS
update, is it?). This change does a lot of things, and
I haven't spotted anything yet that is *required* for
SMBIOS 3.2.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 11:
Please elaborate more about the change. Thread counts on so on.
I think most of all, this commit message needs to give a reason
for the changes. If all the added fields (I haven't checked) are
optional in SMBIOS 3.2, then this would just be a cosmetic change?
Is it done in preperation for other changes in the queue? or just
for anticipated future changes?
To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 1
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso@intel.corp-partner.google.com>
Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 09:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment