HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc@259 PS4, Line 259: Redundant offset remarks are not useful in any way and are masking useful : # ones that might indicate an issue so it is better to hide them.
hiding a problem doesn't mean problem solved :)
changes for version 20180927: "iASL: Implemented detection of extraneous/redundant uses of the Offset() operator within a Field Unit list. A remark is now issued ...."
and here is the problem :
"Note, when optimization is enabled, the iASL compiler will in fact remove the redundant Offset operators and will not emit any AML code for them"