Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59854 )
Change subject: soc/intel/alderlake: Define soc_get_pcie_rp_type ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/59854/comment/01ce61dc_9e0af18c PS3, Line 23: get_adl_cpu_type do you really want to run through this loop https://review.coreboot.org/c/coreboot/+/57151/3/src/soc/intel/alderlake/cpu...
or Kconfig can also be useful here because we are selecting the PCH type while building SoC layer and such decision can even made while compilation itself? thoughts ?
if (CONFIG(SOC_INTEL_ALDERLAKE_PCH_M)) return pch_m_rp_groups;
return pch_lp_rp_groups;