Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
1 comment:
File src/soc/intel/alderlake/pcie_rp.c:
Patch Set #3, Line 23: get_adl_cpu_type
do you really want to run through this loop https://review.coreboot.org/c/coreboot/+/57151/3/src/soc/intel/alderlake/cpu.c#136
or Kconfig can also be useful here because we are selecting the PCH type while building SoC layer and such decision can even made while compilation itself? thoughts ?
if (CONFIG(SOC_INTEL_ALDERLAKE_PCH_M))
return pch_m_rp_groups;
return pch_lp_rp_groups;
To view, visit change 59854. To unsubscribe, or for help writing mail filters, visit settings.