Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43549/2//COMMIT_MSG Commit Message:
PS2: please use a conventional commit message style.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 16: option RT1011_ALC5682I_I2S 4
Caveh, is it okay to assign 4 to this codec/amplifier? If so, we need to add the program setting.
yes, let's update the program.star first 😊 and add the Cq-Depend.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 18: chip drivers/i2c/rt1011 can you share the latest schematics? the most recent i could find still shows the max98373.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 19: Woofer do you want to keep "Woofer" here or is it just a speaker?
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 21: RTWL rename this if you decide to drop "woofer" from the description.