build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 53:
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5fb9a747_f60b5ec8 PS53, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e4e61b2e_082b229d PS53, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/99b14bb0_630eece9 PS53, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/100889b8_c57f19e6 PS53, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/55d30152_0125cdba PS53, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/0c972ef3_337aeae9 PS53, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b635b3a1_adbcd00a PS53, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/659f14a9_c4db83bd PS53, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/eaaf0e8e_29322386 PS53, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/57741063_2cdb25c0 PS53, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/d78456a6_ef307045 PS53, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c4211645_612eca82 PS53, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/767248c6_8d7d1234 PS53, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/095b287a_0b962ab7 PS53, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/39f0db42_09dd90e2 PS53, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b8ee263f_b7b75c80 PS53, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1f73da02_d9138fa4 PS53, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e175b41e_7d45669e PS53, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/bd5055c3_fb9f9501 PS53, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/db33781a_5edc9823 PS53, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/58d89159_412939e2 PS53, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/f0480931_9c725d8c PS53, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/cdf8d8f0_2c3c6b3a PS53, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/6395762b_0712b5bc PS53, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5ebb5cd0_4fce0f5b PS53, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/9ce9ecdb_8a8f836e PS53, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3b3bde68_685d242b PS53, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5d625f14_7f9f722a PS53, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c95144ce_4c50cd98 PS53, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/14cfd50d_1ed6a168 PS53, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/2bd6a1fa_b814cd3f PS53, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e1c882cb_8365d36c PS53, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a4dec9c6_b98b7894 PS53, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/8df822d0_aa860bdb PS53, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/78103ea6_d3b8bc68 PS53, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c1de70c7_1ee32de1 PS53, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/ed34b9ef_36391bf9 PS53, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1a58a88b_97b262b6 PS53, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/4beecd4a_09b7a597 PS53, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/96f66e41_0f9e1260 PS53, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/331ec5fb_d6e22ceb PS53, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22c15028_3ed62493 PS53, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/39a5b7f5_c3eb7761 PS53, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1ddfd376_dd09f930 PS53, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/8d6a1e57_4e3cd254 PS53, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b1877827_ffa9eec2 PS53, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1701cc5e_7af39cdc PS53, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a5b3b8da_2418c550 PS53, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e139d78f_6e4a3b49 PS53, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3bf024ba_4c4d45b1 PS53, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1bb4d8a5_a169490b PS53, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b58b246b_d038d9b8 PS53, Line 773: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/80ea6a3a_c9e49c07 PS53, Line 778: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/aa4334bb_176e9e56 PS53, Line 783: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/f04d8e85_526b0c23 PS53, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a4791b26_8e36f4db PS53, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/cfe71705_4080943b PS53, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5e0e3b0a_2bbb3e04 PS53, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3e4bfb39_6e10a4c3 PS53, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22d86baf_ac0fb35a PS53, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/2f2fbb5b_55be2daa PS53, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/7ac6ffd0_12255636 PS53, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b23b40f5_58a7b211 PS53, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22e106af_ffbb1f12 PS53, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters