Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 )
Change subject: mb/lenovo: Add Lenovo Thinkpad Helix ......................................................................
Patch Set 1:
(1 comment)
Just remembered I had rewritten autoport's README, and that it has an explanation about SPD stuffs.
https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/romstage.... File src/mainboard/lenovo/helix/romstage.c:
https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/romstage.... PS1, Line 71: read_spd(&spd[0], 0x50, id_only); : read_spd(&spd[1], 0x52, id_only); : read_spd(&spd[2], 0x51, id_only); : read_spd(&spd[3], 0x53, id_only); Are you sure? There's a section about SPD here, and also talks about soldered memory:
https://github.com/coreboot/coreboot/blob/master/util/autoport/readme.md