Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 ) Change subject: mb/lenovo: Add Lenovo Thinkpad Helix ...................................................................... Patch Set 1: (1 comment) Just remembered I had rewritten autoport's README, and that it has an explanation about SPD stuffs. https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/romstage.... File src/mainboard/lenovo/helix/romstage.c: https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/romstage.... PS1, Line 71: read_spd(&spd[0], 0x50, id_only); : read_spd(&spd[1], 0x52, id_only); : read_spd(&spd[2], 0x51, id_only); : read_spd(&spd[3], 0x53, id_only); Are you sure? There's a section about SPD here, and also talks about soldered memory: https://github.com/coreboot/coreboot/blob/master/util/autoport/readme.md -- To view, visit https://review.coreboot.org/c/coreboot/+/33867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dbf10bc85edb161fce077568d4ef3db91e10db7 Gerrit-Change-Number: 33867 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Peter Lemenkov <lemenkov@gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2019 15:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment