Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )
Change subject: mb/lenovo/x60: Override default SPI OPs
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/33041/12/src/mainboard/lenovo/x60/m...
File src/mainboard/lenovo/x60/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33041/12/src/mainboard/lenovo/x60/m...
PS12, Line 75: .ops = {{0x01, WRITE_NO_ADDR}, /* WRSR: Write Status Register */
Put a line break between the opening braces?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f
Gerrit-Change-Number: 33041
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 06 Jul 2019 23:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment