Change in ...coreboot[master]: mb/lenovo/x60: Override default SPI OPs

List overview All Threads
Download

newer

older

[M] Change in coreboot[master]:...

[M] Change in blobs[master]:...

Arthur Heymans (Code Review)

28 May 2019 28 May '19

1:07 p.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33041

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

mb/lenovo/x60: Override default SPI OPs

The thinkpad X60 with SST flash needs different SPI OPs to make flashrom happy. flashrom uses AAI for writing.

One potential issue is that fast_read is not possible anymore, but on x86 the flash is memory mapped so this won't matter.

Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x60/mainboard.c 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33041/1

diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c index 274a151..3aef020 100644 --- a/src/mainboard/lenovo/x60/mainboard.c +++ b/src/mainboard/lenovo/x60/mainboard.c @@ -15,6 +15,7 @@ * GNU General Public License for more details. */

+#include <spi_flash.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/device.h> @@ -26,6 +27,7 @@ #include <drivers/intel/gma/int15.h> #include <drivers/lenovo/lenovo.h> #include <arch/acpigen.h> +#include <southbridge/intel/common/spi.h>

#define PANEL INT15_5F35_CL_DISPLAY_DEFAULT

@@ -66,6 +68,28 @@ return ARRAY_SIZE(cst_entries); }

+ +static const struct intel_spi_config spi_config_sst = { + .opprefixes = {0x06, 0x50}, + .ops = {{0x01, WRITE_NO_ADDR}, /* WRSR: Write Status Register */ + {0x02, WRITE_WITH_ADDR}, /* BYPR: Byte Program */ + {0x03, READ_WITH_ADDR}, /* READ: Read Data */ + {0x05, READ_NO_ADDR}, /* RDSR: Read Status Register */ + {0x20, WRITE_WITH_ADDR}, /* SE20: Sector Erase 0x20 */ + {0x9f, READ_NO_ADDR}, /* RDID: Read ID */ + {0xad, WRITE_NO_ADDR}, /* Auto Address Increment Word Program */ + {0x04, WRITE_NO_ADDR}} /* Write Disable */ +}; + +void intel_southbridge_override_spi(struct intel_spi_config *spi_config) +{ + const struct spi_flash *flash = boot_device_spi_flash(); + + if (strcmp(flash->name, "SST25VF016B") == 0) { + memcpy(spi_config, &spi_config_sst, sizeof(spi_config_sst)); + } +} + static void mainboard_init(struct device *dev) { struct device *idedev, *sdhci_dev;

Attachments:

attachment.htm (text/html — 5.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

28 May 28 May

1:08 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33041/1/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/1/src/mainboard/lenovo/x60/mainboard.c... PS1, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 May 2019 13:08:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

1:09 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33041/2/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/2/src/mainboard/lenovo/x60/mainboard.c... PS2, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 May 2019 13:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

1:25 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33041/3/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/3/src/mainboard/lenovo/x60/mainboard.c... PS3, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 May 2019 13:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

4 Jun 4 Jun

1:07 p.m.

Hello Thomas Heijligen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33041

to look at the new patch set (#4).

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

mb/lenovo/x60: Override default SPI OPs

The thinkpad X60 with SST flash needs different SPI OPs to make flashrom happy. flashrom uses AAI for writing.

One potential issue is that fast_read is not possible anymore, but on x86 the flash is memory mapped so this won't matter.

Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x60/mainboard.c 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33041/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

1:08 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/33041/4/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/4/src/mainboard/lenovo/x60/mainboard.c... PS4, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Jun 2019 13:08:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

1:47 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33041/5/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/5/src/mainboard/lenovo/x60/mainboard.c... PS5, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Jun 2019 13:47:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

2:19 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33041/5/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/5/src/mainboard/lenovo/x60/mainboard.c... PS5, Line 89: memcpy(spi_config, &spi_config_sst, sizeof(spi_config_sst)); Struct of same type can be assigned, IIRC:

*spi_config = spi_config_sst;

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 04 Jun 2019 14:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11 Jun 11 Jun

9:30 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/33041/6/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/6/src/mainboard/lenovo/x60/mainboard.c... PS6, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 11 Jun 2019 09:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:46 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/33041/7/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/7/src/mainboard/lenovo/x60/mainboard.c... PS7, Line 81: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 11 Jun 2019 09:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

15 Jun 15 Jun

4:33 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/33041/8/src/mainboard/lenovo/x60/mainboard.c File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/#/c/33041/8/src/mainboard/lenovo/x60/mainboard.c... PS8, Line 82: {0x04, WRITE_NO_ADDR}} /* Write Disable */ space required after that close brace '}'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 15 Jun 2019 16:33:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

4:40 p.m.

Hello Thomas Heijligen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33041

to look at the new patch set (#9).

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

mb/lenovo/x60: Override default SPI OPs

The thinkpad X60 with SST flash needs different SPI OPs to make flashrom happy. flashrom uses AAI for writing.

One potential issue is that fast_read is not possible anymore, but on x86 the flash is memory mapped so this won't matter.

Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x60/mainboard.c 1 file changed, 25 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33041/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

6 Jul 6 Jul

11 p.m.

New subject: Change in coreboot[master]: mb/lenovo/x60: Override default SPI OPs

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Patch Set 12: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/33041/12/src/mainboard/lenovo/x60/m... File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/c/coreboot/+/33041/12/src/mainboard/lenovo/x60/m... PS12, Line 75: .ops = {{0x01, WRITE_NO_ADDR}, /* WRSR: Write Status Register */ Put a line break between the opening braces?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 06 Jul 2019 23:00:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

6 Oct 6 Oct

10:14 p.m.

New subject: Change in coreboot[master]: mb/lenovo/x60: Override default SPI OPs

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Arthur Heymans (Code Review)

10 May 10 May

3:13 p.m.

New subject: [S] Change in coreboot[master]: mb/lenovo/x60: Override default SPI OPs

Arthur Heymans has restored this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: restore

Arthur Heymans (Code Review)

3:16 p.m.

New subject: [S] Change in coreboot[master]: mb/lenovo/x60: Override default SPI OPs

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33041 )

Change subject: mb/lenovo/x60: Override default SPI OPs ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65fc632b33962bd505283c842c45feb85c75e5f Gerrit-Change-Number: 33041 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

444

days inactive

1887

days old

coreboot-gerrit@coreboot.org

15 comments

3 participants

tags (0)

participants (3)

Arthur Heymans (Code Review)
build bot (Jenkins) (Code Review)
Nico Huber (Code Review)