build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 12:
(22 comments)
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... File src/security/intel/stm/SmmStm.h:
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... PS12, Line 31: uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase, trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... PS12, Line 106: uint8_t * stm_resource_heap = NULL; "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... PS12, Line 343: __func__, trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... PS12, Line 345: resource->header.rsc_type, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Smm... PS12, Line 345: resource->header.rsc_type, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 46: {{MEM_RANGE, sizeof(STM_RSC_MEM_DESC)}, that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 73: static STM_RSC_END rsc_list_end __attribute__((used)) = trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 74: {{END_OF_RESOURCES, sizeof(STM_RSC_END)}, 0}; that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 167: Status = add_pi_resource((void *)&rsc_pm_io, 1); trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 106: void * smbase_processor; "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 110: trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 117: trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 120: printk(BIOS_DEBUG, trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 148: // smbase and not the one for the smi handler in tseg. So we have trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 150: trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 159: smbase, psd); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 159: smbase, psd); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 162: extern uint8_t * stm_resource_heap; "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 166: void stm_setup(uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase, trailing whitespace
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 174: if(cpu == 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 174: if(cpu == 0) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/33234/12/src/security/intel/stm/Stm... PS12, Line 179: trailing whitespace