22 comments:
File src/security/intel/stm/SmmStm.h:
Patch Set #12, Line 31: uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase,
trailing whitespace
File src/security/intel/stm/SmmStm.c:
Patch Set #12, Line 106: uint8_t * stm_resource_heap = NULL;
"foo * bar" should be "foo *bar"
Patch Set #12, Line 343: __func__,
trailing whitespace
Patch Set #12, Line 345: resource->header.rsc_type,
code indent should use tabs where possible
Patch Set #12, Line 345: resource->header.rsc_type,
please, no space before tabs
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #12, Line 46: {{MEM_RANGE, sizeof(STM_RSC_MEM_DESC)},
that open brace { should be on the previous line
Patch Set #12, Line 73: static STM_RSC_END rsc_list_end __attribute__((used)) =
trailing whitespace
Patch Set #12, Line 74: {{END_OF_RESOURCES, sizeof(STM_RSC_END)}, 0};
that open brace { should be on the previous line
Patch Set #12, Line 167: Status = add_pi_resource((void *)&rsc_pm_io, 1);
trailing whitespace
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #12, Line 106: void * smbase_processor;
"foo * bar" should be "foo *bar"
trailing whitespace
trailing whitespace
Patch Set #12, Line 120: printk(BIOS_DEBUG,
trailing whitespace
Patch Set #12, Line 148: // smbase and not the one for the smi handler in tseg. So we have
trailing whitespace
trailing whitespace
Patch Set #12, Line 159: smbase, psd);
code indent should use tabs where possible
Patch Set #12, Line 159: smbase, psd);
please, no spaces at the start of a line
Patch Set #12, Line 162: extern uint8_t * stm_resource_heap;
"foo * bar" should be "foo *bar"
Patch Set #12, Line 166: void stm_setup(uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase,
trailing whitespace
Patch Set #12, Line 174: if(cpu == 0)
that open brace { should be on the previous line
Patch Set #12, Line 174: if(cpu == 0)
space required before the open parenthesis '('
trailing whitespace
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.