Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: b/google/vilboz: enable wifi module ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Change looks good, just some minor updates to commit message.
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: enable wifi module Fix variant ID for v3+ schematics for vilboz
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: b mb
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@8 PS2, Line 8: : At this moment Vilboz board version is 1, : so we need to configure it At this moment, Vilboz board version is 1 and it follows v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.