Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: b/google/vilboz: enable wifi module ......................................................................
b/google/vilboz: enable wifi module
At this moment Vilboz board version is 1, so we need to configure it
BUG=b:160547115 BRANCH=None TEST=flash the bios to vilboz DUT and test WIFI module
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997 --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43161/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index e24f78a..19225d7 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -142,13 +142,13 @@ default 3 if BOARD_GOOGLE_MORPHIUS default 2 if BOARD_GOOGLE_BERKNIP default 3 if BOARD_GOOGLE_DALBOZ - default 2 if BOARD_GOOGLE_VILBOZ + default 1 if BOARD_GOOGLE_VILBOZ default 256
config VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW int default 3 if BOARD_GOOGLE_BERKNIP - default 3 if BOARD_GOOGLE_VILBOZ + default 2 if BOARD_GOOGLE_VILBOZ default VARIANT_MIN_BOARD_ID_V3_SCHEMATICS
endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: b/google/vilboz: enable wifi module ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Change looks good, just some minor updates to commit message.
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: enable wifi module Fix variant ID for v3+ schematics for vilboz
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: b mb
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@8 PS2, Line 8: : At this moment Vilboz board version is 1, : so we need to configure it At this moment, Vilboz board version is 1 and it follows v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43161
to look at the new patch set (#3).
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz
At this moment, Vilboz board version is 1 and it follows v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.
BUG=b:160547115 BRANCH=None TEST=flash the bios to vilboz DUT and test WIFI module
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997 --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43161/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: enable wifi module
Fix variant ID for v3+ schematics for vilboz
Done
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@7 PS2, Line 7: b
mb
Done
https://review.coreboot.org/c/coreboot/+/43161/2//COMMIT_MSG@8 PS2, Line 8: : At this moment Vilboz board version is 1, : so we need to configure it
At this moment, Vilboz board version is 1 and it follows v3+ schematics, however WiFi power enable i […]
Done
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
Patch Set 3: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@8 PS3, Line 8: for vilboz Please put that on the line above.
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@10 PS3, Line 10: At this moment, Vilboz board version is 1 and it : follows v3+ schematics, however WiFi power enable : is active high. … according to the schematics?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43161
to look at the new patch set (#4).
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz
At this moment, Vilboz board version is 1 and it according to v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.
BUG=b:160547115 BRANCH=None TEST=flash the bios to vilboz DUT and test WIFI module
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997 --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43161/4
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@8 PS3, Line 8: for vilboz
Please put that on the line above.
Done
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@10 PS3, Line 10: At this moment, Vilboz board version is 1 and it : follows v3+ schematics, however WiFi power enable : is active high.
… according to the schematics?
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz
At this moment, Vilboz board version is 1 and it according to v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.
BUG=b:160547115 BRANCH=None TEST=flash the bios to vilboz DUT and test WIFI module
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index e24f78a..19225d7 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -142,13 +142,13 @@ default 3 if BOARD_GOOGLE_MORPHIUS default 2 if BOARD_GOOGLE_BERKNIP default 3 if BOARD_GOOGLE_DALBOZ - default 2 if BOARD_GOOGLE_VILBOZ + default 1 if BOARD_GOOGLE_VILBOZ default 256
config VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW int default 3 if BOARD_GOOGLE_BERKNIP - default 3 if BOARD_GOOGLE_VILBOZ + default 2 if BOARD_GOOGLE_VILBOZ default VARIANT_MIN_BOARD_ID_V3_SCHEMATICS
endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ
-
Furquan Shaikh (Code Review) -
Kangheui Won (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)