Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8
......................................................................
Patch Set 11:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64...
File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64...
PS6, Line 47: VIRT_FLASH_START
There's no SRAM, so placing it in DRAM is fine. […]
Does the placing BOOTBLOCK in DRAM mean it doesn't use Cache-As-RAM?
Did the old armv8 port set up DRAM in bootblock_custom.S or is it fine just doing a copy bootblock code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c0831b1ecf08785b4ec8139d809bad9b3e1eec
Gerrit-Change-Number: 33387
Gerrit-PatchSet: 11
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 09:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Asami Doi
d0iasm.pub@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment
