[coreboot-gerrit] Change in coreboot[master]: mb/51nb: Add support for the 51nb X210

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )

Change subject: mb/51nb: Add support for the 51nb X210
......................................................................

Patch Set 40:

(1 comment)

the SMI I/O Trap looks a bit suspicious to me; smells like some leftover from vendor firmware. what is that needed for and is the SMI handler for this even in place?

https://review.coreboot.org/c/coreboot/+/32531/40/src/mainboard/51nb/x210/de... 
File src/mainboard/51nb/x210/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/32531/40/src/mainboard/51nb/x210/de... 
PS40, Line 77: 	# VR Settings Configuration for 4 Domains
do the voltage regulator settings need to be in the devicetree? at least for some platforms there were patches to have the defaults in the platform code