Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer: Add a DPTF policy for Eldrid ......................................................................
Patch Set 25:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@2 PS22, Line 2: nick_xr_chen
Please use *Nick Chen*.
Done
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@10 PS22, Line 10: 2. Update tcc offset to 5
Please remove the trailing space.
Done
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@12 PS22, Line 12:
Who gave you the number?
Base on b:/170357248#4, the value is decided by thermal team
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@15 PS22, Line 15: nick_xr_chen
Nick Chen
Done
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... PS22, Line 79: register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)" : register "policies.passive[3]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
Sorry Nick, I got myself confused the other day 😞 […]
Thanks for your support. We just concern cpu and temp_sensor_2 so we only add [0] and [3] on the register. Is the change correct?
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... PS22, Line 82: ## Critical Policy : register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)" : register "policies.critical[3]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
I apologize, the same thing here: […]
Same as above.