6 comments:
Patch Set #22, Line 2: nick_xr_chen
Please use *Nick Chen*.
Done
Patch Set #22, Line 10: 2. Update tcc offset to 5
Please remove the trailing space.
Done
Who gave you the number?
Base on b:/170357248#4, the value is decided by thermal team
Patch Set #22, Line 15: nick_xr_chen
Nick Chen
Done
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)"
register "policies.passive[3]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
Sorry Nick, I got myself confused the other day 😞 […]
Thanks for your support.
We just concern cpu and temp_sensor_2 so we only add [0] and [3] on the register.
Is the change correct?
## Critical Policy
register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)"
register "policies.critical[3]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
I apologize, the same thing here: […]
Same as above.
To view, visit change 45860. To unsubscribe, or for help writing mail filters, visit settings.