[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu1: initialize serial port in bootblock

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37332 )

Change subject: mb/pcengines/apu1: initialize serial port in bootblock
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37332/1/src/mainboard/pcengines/apu... 
File src/mainboard/pcengines/apu1/bootblock.c:

https://review.coreboot.org/c/coreboot/+/37332/1/src/mainboard/pcengines/apu... 
PS1, Line 15: #include <device/pnp.h>
> Doesn't PNP_DEV macro require include?

Yes, but not this one. Rather:

src/include/device/pnp_type.h: #define PNP_DEV(PORT, FUNC) (((PORT) << 8) | (FUNC))