Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40303 )
Change subject: mb/google/octopus/variants/bobba: Disable XHCI LFPS power management ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40303/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/40303/7/src/mainboard/google/octopu... PS7, Line 95: case 44: Bobba variant here supports bobba/sparky/droid/blorb/droid-lte as I know and looks like the disable_xhci_lfps_pm is for droid-lte only.
As a result, - it looks like bobba / sparky skus should be listed here as well? otherwise they will be impacted. - since droid-lte skus are fewer, could we set default disable_xhci_lfps_pm to 0 then enable it for droid-lte skus here?