Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45630 )
Change subject: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v3373
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG@12
PS1, Line 12: Includes
include
Ack
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG@13
PS1, Line 13: ITbtPcieTunnelingForUsb4
: SlowSlewRate
: FastPkgCRampDisable
Please format it as a list.
Ack
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG@17
PS1, Line 17: BUG=b:
b:153015585
@Tim, cros-bug is 169759177. Have more details there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e28905f8f7241940ea92ac3e83b52ff7948953a
Gerrit-Change-Number: 45630
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Levin
levinale@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 19:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment