Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32651/4/src/soc/amd/common/block/gpio_banks/... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/#/c/32651/4/src/soc/amd/common/block/gpio_banks/... PS4, Line 53: configure_gevent_smi
This is part of original code, for runtime warning if SMI is disabled. […]
Yes, that's right Richard. soc//stoneyridge is still a lot like the older cpu/nb/sb implementations that can be build with or without HAVE_SMI_HANDLER selected. However it, like newer Intel devices, relies on having SMI to do its CPU setup.
Given that we won't implement another device the old way, I think this is the right time to take it out. I'll add a note to the commit message. Removing the stoneyridge/Makefile.inc dependencies on CONFIG_HAVE_SMI_HANDLER can go into a separate patch.
https://review.coreboot.org/#/c/32651/5/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/gpio.h:
https://review.coreboot.org/#/c/32651/5/src/soc/amd/common/block/include/amd... PS5, Line 2: * This file is part of the coreboot project.
Is this file still needed? It's the same as gpio_banks. […]
No, not supposed to be here. Some combination of git mv and fixing up went wrong. Will update it right now.