2 comments:
File src/soc/amd/common/block/gpio_banks/gpio.c:
Patch Set #4, Line 53: configure_gevent_smi
This is part of original code, for runtime warning if SMI is disabled. […]
Yes, that's right Richard. soc//stoneyridge is still a lot like the older cpu/nb/sb implementations that can be build with or without HAVE_SMI_HANDLER selected. However it, like newer Intel devices, relies on having SMI to do its CPU setup.
Given that we won't implement another device the old way, I think this is the right time to take it out. I'll add a note to the commit message. Removing the stoneyridge/Makefile.inc dependencies on CONFIG_HAVE_SMI_HANDLER can go into a separate patch.
File src/soc/amd/common/block/include/amdblocks/gpio.h:
Patch Set #5, Line 2: * This file is part of the coreboot project.
Is this file still needed? It's the same as gpio_banks. […]
No, not supposed to be here. Some combination of git mv and fixing up went wrong. Will update it right now.
To view, visit change 32651. To unsubscribe, or for help writing mail filters, visit settings.