Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47769 )
Change subject: util/amdfwtool: Fix EFS generation polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47769/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/47769/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1206: amd_romsig->second_gen_efs = 0xfffffffe;
i'd add and use defines for the EFS generation values and assign them to the struct field. […]
already commented on the internal brach, but I'd like to keep all assignments so that you don't have to read the calling function rather closely and use ~0 and ~1 as right hand side in the assignments, since that makes it clearer where that value comes from. no need for defines here imho