View Change

1 comment:

• File util/amdfwtool/amdfwtool.c:

  • Patch Set #1, Line 1206: amd_romsig->second_gen_efs = 0xfffffffe;

    i'd add and use defines for the EFS generation values and assign them to the struct field. […]

    already commented on the internal brach, but I'd like to keep all assignments so that you don't have to read the calling function rather closely and use ~0 and ~1 as right hand side in the assignments, since that makes it clearer where that value comes from. no need for defines here imho

To view, visit change 47769. To unsubscribe, or for help writing mail filters, visit settings.