Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40536 )
Change subject: soc/intel/jasperlake: Add support to generate ACPI GPIO operations
......................................................................
Patch Set 1: Code-Review+2
FYI there's supposed to be a follow-up patch from someone else to clean up all of these copy-pasted acpigen_soc_gpio* functions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc4846fbd9baf4f22c48c82acefed960669ed7d4
Gerrit-Change-Number: 40536
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:05:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment