Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33797 )
Change subject: arch/riscv: Fix arch timer timebase ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c File src/arch/riscv/arch_timer.c:
https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c@31 PS1, Line 31: die("time not set in HLS");
Well 'die()' is just another 'printk()' called before 'console_init()' here that would not show up, […]
It might end in an recursion, but I don't see an easy fix for now. We could just increment a static software counter each time this function is called.
https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c@33 PS1, Line 33: die("Unsupported mtime clock frequency");
Like Philip said. […]
Done.
https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c@36 PS1, Line 36: mono_time_set_usecs(mt, (long)(raw / clocks_per_usec));
unsigned long ? […]
mono_time_set_usecs takes a long as argument. That's the way it's implemented all over in coreboot. Updated comments.