View Change

3 comments:

• File src/arch/riscv/arch_timer.c:

  • Patch Set #1, Line 31: die("time not set in HLS");

    Well 'die()' is just another 'printk()' called before 'console_init()' here that would not show up, […]

    It might end in an recursion, but I don't see an easy fix for now.
    We could just increment a static software counter each time this function is called.

  • Patch Set #1, Line 33: die("Unsupported mtime clock frequency");

    Like Philip said. […]

    Done.

  • Patch Set #1, Line 36: mono_time_set_usecs(mt, (long)(raw / clocks_per_usec));

    unsigned long ? […]

    mono_time_set_usecs takes a long as argument.
    That's the way it's implemented all over in coreboot. Updated comments.

To view, visit change 33797. To unsubscribe, or for help writing mail filters, visit settings.