Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 65: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... PS65, Line 674: /* WBEC: Calls SMI function 0x11 */ Those SMI functions are not there on coreboot, are they?
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 170: x4
Okay, thanks. I see from FspmUpd. […]
"Peg" usually refers to the PCIe lanes attached to the CPU, which do not exist on SKL-U
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 240: device pci 01.0 on end # Dedicated Graphics Device
Notice that, on line 371, coreboot says it could not find this device. That is, Bus:Dev.Fun 00:01. […]
Done
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 46: // Mainboard specific
Were you referring to mbdefines. […]
Right. The idea is to avoid having both "mbdefines" and "mainboard", as they sound a bit redundant.