Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49100 )
Change subject: mb/intel/adlrvp: Fix FW download failed for PEG 060, 010 ......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49100/comment/c316f5e0_849620a1 PS1, Line 72: PcieRpEnable
There is some disconnect here. PcieRpEnable[0] refers to PCH PCIe RP 1. […]
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49100/comment/881836a1_703aefd3 PS2, Line 72: PcieRpEnable
we have internal bug file, i will raise a crossbug
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49100/comment/3af73f03_50200bfe PS3, Line 72: register "PcieRpEnable[0]" = "1
a comment here why you're using `PcieRpEnable instead of `CpuPcieRpEnable` would be helpful here
Ack