Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/acpi/sandybridge.asl:
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy...
PS1, Line 68: PXSZ
It's a 2-bit value. Missing some cases. […]
`>>` seems correct and is what newer copies of the code do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Feb 2020 15:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment