Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46657 )
Change subject: soc/intel/xeon_sp: Add a smm_region function ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46657/1/src/soc/intel/xeon_sp/memma... File src/soc/intel/xeon_sp/memmap.c:
https://review.coreboot.org/c/coreboot/+/46657/1/src/soc/intel/xeon_sp/memma... PS1, Line 5: pci
pci_ops ?
Done
https://review.coreboot.org/c/coreboot/+/46657/1/src/soc/intel/xeon_sp/memma... PS1, Line 11: PCI_DEV(0, VTD_DEV, VTD_FUNC)
Maybe #define this?
Done
https://review.coreboot.org/c/coreboot/+/46657/1/src/soc/intel/xeon_sp/memma... PS1, Line 16: tseg_base &= 0xfff00000;
I'd use: […]
Done
https://review.coreboot.org/c/coreboot/+/46657/1/src/soc/intel/xeon_sp/memma... PS1, Line 19: this effectively means
nit: Move this part to the next line, so that the comment is more rectangular
Done