Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49056 )
Change subject: [TEST] abuild: Default to !CHROMEOS ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49056/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49056/4//COMMIT_MSG@7 PS4, Line 7: [TEST]
Well, I don't know why CHROMEOS would default to y.
I meant drop the [TEST] part, as highlighted :)
Is this supposed to be submitted? I'm kinda confused as to the point of this patch, isn't !CHROMEOS already the default?
the point is to force abuild to test the !CHROMEOS case for boards which default to CHROMEOS=y without having to create special configs for them. Ideally, all of those boards should have that default removed, but this serves as a backstop against new ones being added with it defaulting to Y and then the !CHROMEOS case not being tested and winding up broken, as the 4 preceding patches address