View Change
1 comment:
Commit Message:
Patch Set #4, Line 7: [TEST]
Well, I don't know why CHROMEOS would default to y.
I meant drop the [TEST] part, as highlighted :)
Is this supposed to be submitted? I'm kinda confused as to the point of this patch, isn't !CHROMEOS already the default?
the point is to force abuild to test the !CHROMEOS case for boards which default to CHROMEOS=y without having to create special configs for them. Ideally, all of those boards should have that default removed, but this serves as a backstop against new ones being added with it defaulting to Y and then the !CHROMEOS case not being tested and winding up broken, as the 4 preceding patches address
To view, visit change 49056. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4bc22f70be5b8d8efa35f0cc8aa2d36a5531a
Gerrit-Change-Number: 49056
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 06 Jan 2021 01:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment