Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35271 )
Change subject: soc/amd/common/lpc: Add SuperIO decode function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... PS1, Line 78: #define DECODE_SIO_4E4F 1 Reading the code is obvious, but not here. Could you please add a comment indicating that these 2 values refer to the bit that needs to be set (from DECODE_ALTERNATE_SIO_ENABLE and DECODE_SIO_ENABLE)? Or maybe (changing the code) use: DECODE_SIO_BOTH (DECODE_SIO_ENABLE | DECODE_ALTERNATE_SIO_ENABLE) DECODE_SIO_4E4f DECODE_ALTERNATE_SIO_ENABLE DECODE_SIO_2E2F DECODE_SIO_ENABLE DECODE_SIO_MASK DECODE_SIO_BOTH