1 comment:
File src/soc/amd/common/block/include/amdblocks/lpc.h:
Patch Set #1, Line 78: #define DECODE_SIO_4E4F 1
Reading the code is obvious, but not here. Could you please add a comment indicating that these 2 values refer to the bit that needs to be set (from DECODE_ALTERNATE_SIO_ENABLE and DECODE_SIO_ENABLE)? Or maybe (changing the code) use:
DECODE_SIO_BOTH (DECODE_SIO_ENABLE | DECODE_ALTERNATE_SIO_ENABLE)
DECODE_SIO_4E4f DECODE_ALTERNATE_SIO_ENABLE
DECODE_SIO_2E2F DECODE_SIO_ENABLE
DECODE_SIO_MASK DECODE_SIO_BOTH
To view, visit change 35271. To unsubscribe, or for help writing mail filters, visit settings.