Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for SMBIOS update to version 3.2
......................................................................
Patch Set 12: -Code-Review
Patch Set 12:
(2 comments)
Patch Set 11:
(4 comments)
Line 7:What is "32 bits SMBIOS"?
It was reference to the 32-bit entry point mention in the section 5.2.1 Comment is now removed.
Line 10: Please provide the reason for this change.
This was a request from one of the reviewer, and he did not provide a reason for it. Comment removed as well.
Take back my +2 until Nico's comment get addressed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sun, 14 Apr 2019 06:41:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment