Patch Set 12:


Patch Set 11:


Line 7:What is "32 bits SMBIOS"?
It was reference to the 32-bit entry point mention in the section 5.2.1 Comment is now removed.

Line 10: Please provide the reason for this change.
This was a request from one of the reviewer, and he did not provide a reason for it. Comment removed as well.

Take back my +2 until Nico's comment get addressed.

Patch set 12:-Code-Review

View Change

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Lijian Zhao <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: HAOUAS Elyes <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Sun, 14 Apr 2019 06:41:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment